Skip to content

Revert: Remove WP Multisite WaaS branding and incorrect network-wide warning#597

Merged
superdav42 merged 1 commit into
mainfrom
revert/waas-domain-rename
Mar 28, 2026
Merged

Revert: Remove WP Multisite WaaS branding and incorrect network-wide warning#597
superdav42 merged 1 commit into
mainfrom
revert/waas-domain-rename

Conversation

@superdav42

@superdav42 superdav42 commented Mar 27, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

Reverts commit a205ea8 which incorrectly:

  1. Used outdated "WP Multisite WaaS" branding instead of "Ultimate Multisite"
  2. Added misleading warning that changing the primary domain affects "the entire network"

What This Reverts

  • Removes "Main WP Multisite WaaS Domain" label (back to "Primary Domain")
  • Removes incorrect tooltip claiming changes affect "all URLs across your entire WP Multisite WaaS network"
  • Removes red toggle styling (wu-primary-domain-field CSS)
  • Removes JavaScript confirmation dialog

Why

The primary domain toggle only affects one site, not the entire multisite network. The warning was factually incorrect and could confuse users.

Files Changed

  • assets/css/admin.css & .min.css
  • assets/js/admin.js & .min.js
  • inc/admin-pages/class-domain-edit-admin-page.php
  • inc/admin-pages/class-domain-list-admin-page.php

Related

Summary by CodeRabbit

  • Style

    • Removed red/danger styling from the primary domain toggle.

  • Refactor

    • Eliminated the confirmation dialog when toggling primary domain setting.
    • Simplified primary domain toggle UI with reduced visual emphasis.

@superdav42
Revert "feat: rename Primary Domain to Main WP Multisite WaaS Domain …
e68168e 
…with red toggle and confirmation (#438)"

This reverts commit a205ea8.
@coderabbitai

coderabbitai Bot commented Mar 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 28ff62b4-205e-49e9-8c26-a0e21b22afbd

📥 Commits

Reviewing files that changed from the base of the PR and between aae6149 and e68168e.

⛔ Files ignored due to path filters (1)
  • assets/js/admin.min.js is excluded by !**/*.min.js
📒 Files selected for processing (5)
  • assets/css/admin.css
  • assets/css/admin.min.css
  • assets/js/admin.js
  • inc/admin-pages/class-domain-edit-admin-page.php
  • inc/admin-pages/class-domain-list-admin-page.php
💤 Files with no reviewable changes (1)
  • assets/css/admin.css
📝 Walkthrough

Walkthrough

The PR removes visual styling, user confirmation behavior, and associated metadata from the primary domain toggle control across CSS, JavaScript, and admin page field configurations, simplifying the toggle's implementation.

Changes

Cohort / File(s) Summary
Toggle Styling
assets/css/admin.css		 Removed CSS rules for the checked/active state styling of the primary domain toggle (9 lines deleted).
Event Handling
assets/js/admin.js		 Removed delegated change event handler for [data-wu-primary-domain-toggle] that displayed a confirmation dialog; updated global comment to reference only wu_on_load.
Admin Page Configurations
inc/admin-pages/class-domain-edit-admin-page.php, inc/admin-pages/class-domain-list-admin-page.php		 Removed field metadata (title, desc, tooltip, wrapper_classes, data-wu-primary-domain-toggle), replaced with simplified text and streamlined html_attr containing only v-model binding.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 The toggle sheds its crimson cloak,
No warnings whisper in the smoke,
Simplified and pure and clean,
The simplest toggle ever seen! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing WP Multisite WaaS branding and an incorrect network-wide warning from the primary domain toggle feature.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert/waas-domain-rename

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Mar 27, 2026

Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@github-actions

github-actions Bot commented Mar 27, 2026

Copy link
Copy Markdown

Performance Test Results

Performance test results for e480c21 are in 🛎️!

URL: /

Run DB Queries Memory Before Template Template WP Total LCP TTFB LCP - TTFB
0 41 37.78 MB 889.50 ms 152.00 ms 1064.50 ms 2042.00 ms 1964.60 ms 90.65 ms
1 56 49.01 MB 940.50 ms 141.50 ms 1082.50 ms 2080.00 ms 1998.95 ms 79.20 ms

@superdav42 superdav42 merged commit f829630 into main Mar 28, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@superdav42